Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#57 closed bug (fixed)

Image Browser

Reported by: Mikhail Malyshev Owned by: Thore Böckelmann
Priority: normal Milestone: 3.9-2014R2
Component: Imagebrowser.mui Version: 3.9-nightly build
Severity: minor Keywords:
Cc: OS Platform: AmigaOS3
Blocked By: Blocking:
Release Notes:

Description

The last fix that also refers to #42 has enabled to show all images.
That's good.

Bur now we have two more problems.

  1. Tiny vector versions of XEN scrollbar images, was not fixed
  1. The list is now spread apart too much.

I guess it selects the largest tall image and uses it as a spacer
for all collections. (in my case its about 100 pxls!)

So. We need to raise the size of vector images
and possibly limit the bitmap images to something reasonable.

Attachments (4)

MUI39N-1.png (39.2 KB) - added by Mikhail Malyshev 6 years ago.
Current
MUI39N-4.png (72.8 KB) - added by Mikhail Malyshev 6 years ago.
Older
MUI39N-2.PNG (32.5 KB) - added by Mikhail Malyshev 6 years ago.
New, broken
MUI39N-5.png (67.2 KB) - added by Mikhail Malyshev 6 years ago.
Old, good vector images

Download all attachments as: .zip

Change History (18)

comment:1 Changed 6 years ago by Thore Böckelmann

Milestone: MUI 3.9-2014R2
Priority: undecidednormal
Resolution: wontfix
Status: newclosed
  1. BOOPSI vector images will be displayed larger with the next nightly build, as stated in #52. You really need to wait until the nightly build created on the day following the day the ticket was closed.
  1. The imagebrowser takes the height of the largest image for all images. This is how it works with MUI 3.9. Most probably the vertical images of the "tearoff" collection are the culprit. Do you use them at all? If not, then delete them if you think that they take too much space.

Changed 6 years ago by Mikhail Malyshev

Attachment: MUI39N-1.png added

Current

Changed 6 years ago by Mikhail Malyshev

Attachment: MUI39N-4.png added

Older

Changed 6 years ago by Mikhail Malyshev

Attachment: MUI39N-2.PNG added

New, broken

Changed 6 years ago by Mikhail Malyshev

Attachment: MUI39N-5.png added

Old, good vector images

comment:2 Changed 6 years ago by Mikhail Malyshev

XEN bars have improved, but for some reason the original ones are still a bit small on hight (they are on the right) compared to others that are in the beginning of the list. The older MUI showed them in almost real WYSIWYG mode/size.

Aphaso gadgets are broken in current build, but were ok in MUI39(2005)

comment:3 Changed 6 years ago by Thore Böckelmann

I how far are the Aphaso gadgets broken? You are constantly complaining about different things, but you fail to provide the absolutely necessary basic information.

comment:4 Changed 6 years ago by Mikhail Malyshev

Current
New, broken

Old
Old, good vector images

Don't see the difference in gfx ? (arrows, squares)

comment:5 Changed 6 years ago by Thore Böckelmann

The Aphaso images claim to be resizable by returning suitable dimension information. Obviously they fail to draw themself correctly with a different dimension than the minimum/default dimension. But this is scaling is required for the XEN bars to make them a bit larger than the minimum size.

comment:6 Changed 6 years ago by Mikhail Malyshev

Yes, they are vectors.
And they did not clash with old mui and xen bars.
That were properly sized before.
Older

comment:7 Changed 6 years ago by Thore Böckelmann

Resolution: wontfix
Status: closedreopened

I think I found a solution for this.

comment:8 Changed 6 years ago by Thore Böckelmann

Owner: set to Thore Böckelmann
Resolution: fixed
Status: reopenedclosed

In 3654:

  • Image.c: use the default dimensions for BOOPSI images in the image browser instead of the minimum dimensions. This closes #57.

comment:9 Changed 6 years ago by Thore Böckelmann

Please note that the Aphaso images in priciple still are broken. They claim themself to be scaleable but fail to draw correctly whenever a dimension larger than the minimum/default dimension is requested. This cannot be worked around by MUI.

comment:10 Changed 6 years ago by Mikhail Malyshev

'fail to draw correctly whenever a dimension larger than the minimum/defaul'
No problem with that, just keep all images default 100% size.

comment:11 Changed 6 years ago by Mikhail Malyshev

Now it seems to be ok for all images.
But for some reason the TearOff vector images (zigzag line ones) are twice as big (compared to old MUI) and this does make the whole Lister a bit wide spread.
Not perfect, but well, if you find some more time on this, it would be great to perfect it.

Last edited 6 years ago by Mikhail Malyshev (previous) (diff)

comment:12 in reply to:  11 Changed 6 years ago by Thore Böckelmann

Replying to Michael:

Now it seems to be ok for all images.
But for some reason the TearOff vector images (zigzag line ones) are twice as big (compared to old MUI) and this does make the whole Lister a bit wide spread.

That is because the images are not drawn with their minimum size, but with their default size, which may be a bit larger. Any difference in this respect is due to how a certain method is implemented by the individual class. There is nothing that MUI can do about this. The Aphaso images are definitely buggy in this respect, while the TearOff images are doing everything correctly. They perfectly draw themself as large as requested and this is exactly what you get.

Not perfect, but well, if you find some more time on this, it would be great to perfect it.

There is nothing more I can do here. If MUI 3.8 hid certain bugs there is no reason to hide these bugs any further. This is something that must be accepted. If old stuff is doing things wrong and exploits undocumented features this cannot be always worked around.

comment:13 Changed 6 years ago by Mikhail Malyshev

Update! They look ok in normal resolutions, the problem was with my hi res test.
So it is closed for now.

comment:14 Changed 6 years ago by Thore Böckelmann

Milestone: MUI 3.9-2014R23.9-2014R2

Milestone renamed

Note: See TracTickets for help on using tickets.