Opened 2 months ago

Closed 3 weeks ago

Last modified 3 weeks ago

#449 closed enhancement (fixed)

Native port of MCC_GuiGFX

Reported by: Samir Hawamdeh Owned by: Thore Böckelmann
Priority: normal Milestone: 5.0-2020R2
Component: undefined Version: 5.0-nightly build
Severity: minor Keywords:
Cc: OS Platform: All
Blocked By: Blocking:
Release Notes:

Description

Problem

Some old applications (EaglePlayer to say one) requires the old MCC_GuiGFX MUI class in order to work fully
As the source of this class is freely availible on Aminet i wonder if it can be ported to OS4 and then intregrate it in MUI5

http://aminet.net/package/dev/mui/MCC_Guigfx

Information

Guigfx is a Custom Class for Magic User Interface © by Stefan Stuntz.
It is a subclass of areaclass.
Guigfx.mcc can display image files in any format datatypes.library
understands, guigfx.library image objects, bitmaps and Intuition images.
It supports color depths up to 24bit, transparency channels/masks and
various scaling modes including aspect correction.

This class uses image processing libraries © 1997/98 TEK neoscientists (not
included!)
This class uses MCCLib.c by Kai Hofmann
This distribution installs through MCCInstall by Kai Hofmann
This distribution uses icons shamelessly ripped from AESIcons

Enhancement recommendation

Port to AmigaOS4 PPC and eventually integrate it with future MUI5 release

Change History (8)

comment:1 Changed 2 months ago by Thore Böckelmann

What is wrong with the 68k version, except that it is 68k instead of PPC?

comment:2 Changed 7 weeks ago by Thore Böckelmann

Again: what is wrong with the m68k version? What benefit would a PPC version give us?

comment:3 Changed 7 weeks ago by Samir Hawamdeh

Ops sorry i was completely missed your reply ..
This specific 68k class seems working more or fine under MUI5/OS4 (atleast till now i did not noted any specific issues)
However having a native class and integrate it in the future MUI 5 distributions it may be even better, even because for certain application that need it, users will not be "forced" to download this third party class from elsewhere
Still also that having something PPC native is always better than an emulated one :-)

comment:4 Changed 3 weeks ago by Thore Böckelmann

Milestone: future release5.0-2020R2
Owner: set to Thore Böckelmann
Priority: undecidednormal
Status: newassigned

Having thought several times about this request I came to the conclusing to respect your wish. I skimmed through the original source code of Guigfx class and noticed several flaws and bugs. So it is worth being reimplemented.

comment:5 Changed 3 weeks ago by Thore Böckelmann

Resolution: fixed
Status: assignedclosed

In 6618:

  • mcc/Guigfx.c: added a native reimplementation of Guigfx.mcc. This closes #449.

comment:6 Changed 3 weeks ago by Samir Hawamdeh

Great, thank you :-)
Only a question, for this reimplementation do we still need the old render.library ?

Actually we have a native version of this library however it remains a third-party library to be installed separately.

Perhaps you may include the library into the MUI archive?

comment:7 Changed 3 weeks ago by Thore Böckelmann

Guigfx.mcc requires guigfx.library only, but that library requires render.library internally. Guigfx.mcc is just a MUI wrapper for guigfx.library. Hence guigfx.library (and render.library) are still required. Which version you install (m68k or PPC) is up to you.

Guigfx.mcc is smart enough to handle a missing guigfx.library, just to let the demo application run and display the error message "guigfx.library is missing". Otherwise the demo would not run at all.

Perhaps it will be a good idea to include guigfx.library and render.library. codesets.library is included as well.

comment:8 Changed 3 weeks ago by Thore Böckelmann

In 6619:

  • dist: included native versions of guigfx.library 20.0 and render.library 40.8 to satisfy the requirements of Guigfx.mcc. This refs #449.
Note: See TracTickets for help on using tickets.