Opened 2 years ago

Closed 2 years ago

#380 closed bug (fixed)

MUIM_List_Move is broken

Reported by: Andreas Falkenhahn Owned by: Thore Böckelmann
Priority: normal Milestone: 5.0-2018R2
Component: List.mui Version: 5.0-2018R1
Severity: minor Keywords:
Cc: OS Platform: All
Blocked By: Blocking:
Release Notes:


The following code leads to a program crash on app close if item 0 is active:

DoMethod(list, MUIM_List_Move, 5, MUIV_List_Move_Active);

It also doesn't position items correctly. To reproduce, run the Hollywood applet attached to this ticket, select item 0 and then hit the button. You will see that the item order is not correct. Additionally, the program will crash the system when you try to close the window.

On MUI 3.8 it works fine.

Attachments (1)

test.hwa (1.5 KB) - added by Andreas Falkenhahn 2 years ago.

Download all attachments as: .zip

Change History (3)

Changed 2 years ago by Andreas Falkenhahn

Attachment: test.hwa added

comment:1 Changed 2 years ago by Thore Böckelmann

Component: Listview.muiList.mui
Milestone: future release5.0-2018R2
Owner: set to Thore Böckelmann
Priority: undecidednormal
Status: newassigned

It seems the simple loop for moving the elements having been replaced by a memmove() call is the culprit.

comment:2 Changed 2 years ago by Thore Böckelmann

Resolution: fixed
Status: assignedclosed

In 6296:

  • List.c: fixed the broken MUIM_List_Move implementation. The previous memmove() call corrupts memory for unknown reasons. Hence the old loop based movement has been restored. This closes #380.
Note: See TracTickets for help on using tickets.