Opened 5 years ago

Closed 5 years ago

#154 closed enhancement (fixed)

Opened files on startup of MUIPrefs

Reported by: Mikhail Malyshev Owned by: Thore Böckelmann
Priority: normal Milestone: 4.0-2015R2
Component: Settings.mui Version: 4.0-nightly build
Severity: minor Keywords:
Cc: OS Platform: AmigaOS4
Blocked By: Blocking:
Release Notes:

Description

Just wondering, what's the point of trying to open images files (with localized names) for the prefs items in the main list ?
Ok, I guess we can substitute them for custom images if we like, but why use localized names?

Would not it be better to use english for all languages?

This has two ends of the stick ;-)

  1. Each language can have it's own pictures
  2. We can't have all the images for all the languages.

Possible workaround…

Try localized file name first, then english and if both fail, use internal image.
This would cater for all cases.

Change History (3)

comment:1 Changed 5 years ago by Thore Böckelmann

Component: undefinedSettings.mui
Priority: undecidednormal
Status: newaccepted

This is quite old code which goes back to the time when the page names were not (yet) localized but only english instead. For the internal pages it should not be too hard to define an untranslated name which then results in a fixed image file to be accessed. The pages of custom .mcp classes should provide their own image anyway and even if they fail to do that they still supply a fixed an non-translated name.

comment:2 Changed 5 years ago by Thore Böckelmann

Milestone: 4.0-2015R2
Owner: set to Thore Böckelmann
Status: acceptedassigned

comment:3 Changed 5 years ago by Thore Böckelmann

Resolution: fixed
Status: assignedclosed

In 4490:

  • Settingsgroup.c, Settings.c: enhanced the config prefs page setup to support translated names as well as internal names. The translated names will be visible in the page list of MUI prefs, while the internal names will be used to set up an image path like "MUI:Images/prefs_<page>.mi1". On the one hand this makes it possible to replace the page images of the internal pages. Onthe other hand this allows to provide an image for 3rd party .mcp classes which don't provide an internal image themselves. This closes #154.
Note: See TracTickets for help on using tickets.