Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#125 closed enhancement (fixed)

Keyboard support in Aboutbox

Reported by: Samir Hawamdeh Owned by: Thore Böckelmann
Priority: normal Milestone: 4.0-2015R1
Component: Aboutbox.mcc Version: 4.0-nightly build
Severity: minor Keywords:
Cc: OS Platform: AmigaOS4
Blocked By: Blocking:
Release Notes:

Added support for scrolling virtual groups by keyboard.

Description

Problem

Scrolling in AboutBox are currently supported via mouse wheel, however would be nice to add also some kind of keyboard support too

Enhancement recommendation

You might add the following keys:

ArrowUp/ArrowDown
PageUp/PageDown

Attachments (1)

about.png (58.1 KB) - added by Samir Hawamdeh 4 years ago.
about

Download all attachments as: .zip

Change History (18)

comment:1 Changed 4 years ago by Thore Böckelmann

Milestone: MUI 4.0-2014R6
Owner: set to Thore Böckelmann
Priority: undecidednormal
Status: newassigned

Aboutbox.mcc is just a special case. In fact that feature is better located in Virtgroup.mui to make it available for every scrollable virtual group.

Last edited 4 years ago by Thore Böckelmann (previous) (diff)

comment:2 Changed 4 years ago by Thore Böckelmann

Resolution: fixed
Status: assignedclosed

In 4298:

  • Virtgroup.c, mcc/Aboutbox.c: added keyboard handling to all virtual groups. The typical up/down/left/right shortcuts will move the contents of the virtual group accordingly, but only if it is possible to scroll at all. This closes #125.

comment:3 Changed 4 years ago by Samir Hawamdeh

Mmm are you sure that it works ?

I just tried the keyboard (arrow up/down) on both Odyssey about window and on the NewStuff Aboutbox.mcc demo aswell but both doesn't scroll at all

I'm using the very latest MUI 4.0 SVN r4351

comment:4 Changed 4 years ago by Thore Böckelmann

Resolution: fixed
Status: closedreopened

Hm, when I tested this with WinUAE it worked perfectly. But you are right. With OS4 the key presses are ignored.

comment:5 Changed 4 years ago by Thore Böckelmann

Resolution: fixed
Status: reopenedclosed

In 4356:

  • Virtgroup.c: make use of a private flag for force passing of standard MUI key events to the eventhandler of the virtual group even if it is not the window's active or default object. This closes #125 again.

Changed 4 years ago by Samir Hawamdeh

Attachment: about.png added

about

comment:6 Changed 4 years ago by Samir Hawamdeh

Ehm thank you Thore, but again still not !

Try to scroll the about example (grab above) with the keyboard and you will see…

comment:7 Changed 4 years ago by Thore Böckelmann

Resolution: fixed
Status: closedreopened

comment:8 Changed 4 years ago by Thore Böckelmann

Resolution: fixed
Status: reopenedclosed

In 4359:

  • Virtgroup.c: added the missing IDCMP_RAWKEY for the event handler in the AmigaOS4 build. This is absolutely required when expecting the "muikey" field to be filled with standard MUI key codes. This closes #125 again.

comment:9 Changed 4 years ago by Thore Böckelmann

Milestone: MUI 4.0-2014R6MUI 4.0-2015R1

Milestone renamed

comment:10 Changed 4 years ago by Samir Hawamdeh

Thore if you don't mind i reopen this one because i have an addition request :-)

Keys now works as expected, but would be nice if in the "list" of supported key you can add also that one:

Home / End

(to go directly at the top/bottom)

Thank you ;-)

comment:11 in reply to:  10 Changed 4 years ago by Thore Böckelmann

Replying to samo79:

Home / End

These are supported already. You just need to define proper shortcuts on the Keyboard prefs page of MUI. The top/bottom shortcuts default to "control up/down". It is no problem to add further shortcuts.

"home" and "end" is already used for "start of line" and "end of line".

Last edited 4 years ago by Thore Böckelmann (previous) (diff)

comment:12 Changed 4 years ago by Samir Hawamdeh

Yes i know that i can redefine them, but "home/end" buttons still doesn't work specifically on any of those "MUI4 about" windows … all the other keys to scroll instead are ok

comment:13 Changed 4 years ago by Thore Böckelmann

Of course these keys don't work as you expect it, because you are expecting the wrong behaviour. Home and End refer to horizontal movements, but the virtual group of Aboutbox.mcc can only be scrolled vertically. Home and End are keys for the "start/end of line" shortcuts, not for the "top/bottom of page" shortcuts. You are free to change this, but then string objects will also react wrong, because string objects cannot move the cursor upwards or downwards (unless they consist of multiple lines), but only left and right.

comment:14 Changed 4 years ago by Samir Hawamdeh

@Thore

… because you are expecting the wrong behaviour. Home and End refer to horizontal movements

Ah ok now understand, then it's fine :-)

comment:15 Changed 4 years ago by Thore Böckelmann

Release Notes: modified (diff)

comment:16 Changed 4 years ago by Thore Böckelmann

Milestone: MUI 4.0-2015R14.0-2015R1

Milestone renamed

comment:17 Changed 4 years ago by Thore Böckelmann

In 4505:

  • Virtgroup.c, mcc/Aboutbox.c: moved the keyboard based scrollling from Virtgroup.mui to Aboutbox.mcc where it was originally requested for. This refs #125 and refs #162.
Note: See TracTickets for help on using tickets.