Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#103 closed bug (fixed)

What happend to MUIV_Imageadjust_Type_All?

Reported by: muibase@… Owned by: Thore Böckelmann
Priority: undecided Milestone: 3.9-2014R3
Component: Popimage.mui Version: 4.0-2014R4
Severity: minor Keywords:
Cc: OS Platform: All
Blocked By: Blocking:
Release Notes:

Description

This is mainly for MUI on MorphOS since this is the only system I have access to running MUI 4.0. A copy of this bug description has been shared with the MorphOS team. The intent of posting it here as well, is to have the MUI team check if there has been a bug introduced in MUI 4.0, or if I am doing something wrong.

Back in the days, the author of MUI gave some unofficial info similar to this:

#define MUIA_Imagedisplay_Spec 0x8042a547 /* V11 isg struct MUI_ImageSpec * */

#define MUIA_Imageadjust_Type 0x80422f2b /* V11 i.. LONG */
#define MUIV_Imageadjust_Type_All 0
#define MUIV_Imageadjust_Type_Image 1
#define MUIV_Imageadjust_Type_Background 2
#define MUIV_Imageadjust_Type_Pen 3

This allows to create a popup button for specifying an image. When using *_Type_Background one can set a color, a pattern, or choose an image. The *_Type_All allowed all that plus a few more fancy stuff. This is all still true with MUI 3.8.

The MUI that comes with MorphOS 3.7 still does the same when using *_Type_Background. But *_Type_All and *_Type_Image don't seem to work, they only allow to set a color in the color wheel.

Any idea what happened here?

Steffen

Change History (4)

comment:1 Changed 5 years ago by Thore Böckelmann

That attribute was private for a good reason. If applications start to exploit such undocumented stuff (no matter if the information was spread by Stefan Stuntz or anybody else) then they should accept that things might change in the future which break their possibly wrong usage of that stuff.

I added a special workaround for WookieChat in both MUI 3.9 and MUI4 to for exactly the same issue. But this only works for WookieChat, because the workaround must check for the task name.

Just try how MUI 3.9 and/or MUI4 on AmigaOS behave and please report back here.

Is it MUIBase which requires this kind of undocumented feature to work? If yes, then perhaps we can find a working solution which does not need any of these features. More recent versions of WookieChat were redesigned to define their colors/backgrounds in a different way.

comment:2 Changed 5 years ago by Thore Böckelmann

Milestone: MUI 3.9-2014R3
Owner: set to Thore Böckelmann
Status: newassigned

Since MUI 3.9 suffers from exactly the same effect I will implement all the necessary changes for both MUI 3.9 and MUI4.

comment:3 Changed 5 years ago by Thore Böckelmann

Resolution: fixed
Status: assignedclosed

In 3991:

  • Backgroundadjust.c: made the private value MUIV_Imageadjust_Type_All for the background/image selection working again. Before only a color wheel was offered, although the usual image browser was initialized in the background but was kept invisible. Now it is possible to open a requester to let the user choose from all available image types. Please keep in mind that certain images are *NOT* suitable for every purpose. For example the normal button images should not be used for a background. The reason is that most of these images have transparent regions and using them for a background will cause graphical corruption by left over artifacts after a resize. This finally closes #103.

comment:4 Changed 5 years ago by Thore Böckelmann

Milestone: MUI 3.9-2014R33.9-2014R3

Milestone renamed

Note: See TracTickets for help on using tickets.