Opened 3 weeks ago

Closed 2 weeks ago

Last modified 2 weeks ago

#455 closed bug (fixed)

Current MUI nightly build has already expired

Reported by: Andy Broad Owned by: Thore Böckelmann
Priority: normal Milestone: 5.0-2020R2
Component: Installer script Version: 5.0-2020R1
Severity: minor Keywords:
Cc: OS Platform: undefined
Blocked By: Blocking:
Release Notes:

Description

Summary

When I install the most recent night build from the muidev.de Downloads section (currently dated 1/10/2020 filename MUI-5.0-20201001r6669-os4.lha) on my X1000 it reports that it has expired.

I see the following version reports:

6.NGFSBoot:> version muimaster.library full
muimaster.library 21.204 (17/08/2020)
Copyright © 2006-2020 by Thore Boeckelmann, Jens Maus [AmigaOS4/PPC] [svn r6610] [nightly]

Installed file:

6.NGFSBoot:> version file MUI:Libs/muimaster.library full
muimaster.library 21.204 (17/08/2020)
Copyright © 2006-2020 by Thore Boeckelmann, Jens Maus [AmigaOS4/PPC] [svn r6610] [nightly]

File from installation package:

6.NGFSBoot:> version file RAM:MUI/Libs/muimaster.library full
muimaster.library 21.204 (17/08/2020)
Copyright © 2006-2020 by Thore Boeckelmann, Jens Maus [AmigaOS4/PPC] [svn r6669] [nightly]

Note that although the SVN number has incremented the library version and date has not.

This will stop the install script from installing the library

I will attempt to manually overwrite the library, but I think I tried that on a previous attempt.

My previous attempt to report this issue was rejected as spam, so hopefully this one gets through!

Steps to reproduce

1.
2.

Expected results

Actual results

Regression

Notes

Change History (5)

comment:1 Changed 3 weeks ago by Andy Broad

A manual install did infact solve the issue this time.

comment:2 Changed 3 weeks ago by Thore Böckelmann

Component: undefinedInstaller script
Milestone: future release5.0-2020R2
Owner: set to Thore Böckelmann
Priority: undecidednormal
Status: newassigned

You already noticed the correct issue. muimaster.library itself has not been touched and as such its version has not been bumped. But other components have been touched and hence their version has been bumped. But the Installer application just respects the version numbers and not any custom additional informations. From the Installer point of view muimaster.library is unchanged, although it was rebuilt from scratch with an updated expiry date.

The AutoInstall script already addresses this fact to a certain degree and does not use the rollback feature of AmiUpdate and simply copies all stuff without respecting (unchanged) version numbers. However, the Installer script does not yet do something similar but keeps on respecting (unchanged) version numbers and hence skips obviously unchanged components.

Perhaps I can find something to make Installer handle nightly builds different than normal release builds to copy all components regardless of their version numbers.

comment:3 Changed 3 weeks ago by Thore Böckelmann

Note to myself: the Installer application features the internal "@app-name" variable. perhaps the Install-MUI icon of the nightly builds could set a different application name than the icon of the release builds and let the Installer script differentiate between nightly builds and release builds.

comment:4 Changed 2 weeks ago by Thore Böckelmann

Resolution: fixed
Status: assignedclosed

In 6671:

  • dist: Install-MUI: added a check for the nightly builds. In case of a nightly build archive all the libraries and classes will be copied without respecting the version of already installed libraries and classes. This ensures that the latest versions will be installed, even if just some internal data may have changed but not the version numbers. Additionally the nightly build archives contain special icons for the Installer script to enforce this "nightly build mode". This closes #455.

comment:5 Changed 2 weeks ago by Thore Böckelmann

In 6672:

  • CopyStringBSTRToC.c: just a minor internal but non-functional change, just to trigger a rebuild of muimaster.library with unchanged version number. This refs #455.
Note: See TracTickets for help on using tickets.