Opened 2 weeks ago

Closed 2 weeks ago

Last modified 11 days ago

#426 closed bug (fixed)

ARexx ACTIVATE and DEACTIVATE commands are broken

Reported by: Mike Steed Owned by: Thore Böckelmann
Priority: normal Milestone: 5.0-2020R1
Component: muimaster.library Version: 5.0-2019R4
Severity: minor Keywords:
Cc: OS Platform: AmigaOS4
Blocked By: Blocking:
Release Notes:

Description

Summary

The ARexx DEACTIVATE command does the same thing as the ARexx HIDE command; it should disable processing of Commodities streams. Similarly, the ARexx ACTIVATE command does the same thing as the ARexx SHOW command; it should enable processing of Commodities streams.

Though there's no ready example, I am working on a project that uses Commodities hotkeys, and I can confirm that the "active" and "inactive" commands sent by Commodities Exchange work correctly; it's just the ARexx commands that are broken.

Steps to reproduce

Run a MUI program such as MUI-Demo. Fire up your favorite way of sending ARexx commands to a program (I use TstApp.rexx, attached). Send the DEACTIVATE and ACTIVATE commands to the port MUIDEMO.1.

Expected results

Nothing visible, but the program should internally disable and enable Commodity stream processing. Using my hotkey application, I can confirm that this does not happen.

Actual results

The MUI-Demo program iconifies and restores, just as it does for the HIDE and SHOW commands.

Notes

Bug is also present in MUI 3.9 and MUI 4.

Attachments (1)

TstApp.rexx (2.9 KB) - added by Mike Steed 11 days ago.
Test program to send ARexx commands to an application.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 2 weeks ago by Thore Böckelmann

Owner: set to Thore Böckelmann
Priority: undecidednormal
Reporter: changed from Mike Steed <72207.463@… to Mike Steed <72207.463@…>
Status: newassigned

This seems to be an ancient inconsistency.

You are right that MUI's handling of the ACTIVATE/DEACTIVATE ARexx commands is exactly the same as SHOW/HIDE. But on the other hand these two commands are documented nowhere, at least not in MUI.guide, although their existance can be successfully queried by the INFO command. So one could argue that their handling is either undefined or intentionally the same as SHOW/HIDE. Or Stefan Stuntz simply forgot to implement them properly 20 years ago.

I will see what I can do about this.

You should really get a real account on this side. This makes communication LOTS easier.

comment:2 Changed 2 weeks ago by Thore Böckelmann

Resolution: fixed
Status: assignedclosed

In 6526:

  • masterrexx.c: implemented separate callback functions for the ACTIVATE and DEACTIVCATE ARexx commands. These now correctly enable/disable the application's Commodities interface instead of changing the iconification state. This closes #426.

comment:3 Changed 2 weeks ago by Thore Böckelmann

Reporter: changed from Mike Steed <72207.463@…> to Mike Steed

comment:4 Changed 2 weeks ago by Thore Böckelmann

In 6527:

  • dist_common: added some documentation about the now working ACTIVATE and DEACTIVATE ARexx commands. This refs #426.

Changed 11 days ago by Mike Steed

Attachment: TstApp.rexx added

Test program to send ARexx commands to an application.

comment:5 Changed 11 days ago by Mike Steed

Just for completeness, attached the ARexx test program mentioned in the ticket.

Note: See TracTickets for help on using tickets.