Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#41 closed bug (fixed)

Hits - mesa.mcc

Reported by: mm@… Owned by: Thore Böckelmann
Priority: normal Milestone: 3.9-2014R2
Component: muimaster.library Version: 3.9-2014R1
Severity: minor Keywords:
Cc: OS Platform: AmigaOS3
Blocked By: Blocking:
Release Notes:

Description (last modified by Jens Maus)

Summary

On first opening MUI-Prefs/External - mesa.mcc item we get a hit
After it works ok, no hits. (using d1plus video driver)

06-Jul-14  21:20:05
WARNING: ENFORCER HIT!                                                        
BYTE-READ from 00000062                  PC: 44A3ECB4
USP:  44FB88D8 SR: 0000 FLSW: 01210200 TCB: 44FA92F8
Data: 0000005F 00000003 44FB88FC 0000000F 44FB89E4 44B11EB0 44B53D80 44FB8A68
Addr: 00000062 00000000 455DE760 455E0B00 450F2148 455E0BF0 449A1A50 44FB88D8
Stck: 449EF092 00000062 0000005F 00000000 449A1A50 449EDD60 44F64CF0 00000000
Stck: 450F6FE8 00000062 44F64D4C 450F754C 44FB89D0 44F64CF0 455E0DF8 455E0978
Stck: 455DAC80 455DF4B0 455CA428 455DE5E0 44F64D4C 44FB89C4 44F64D4C 44FB7465
Stck: 73740000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
----> 44A3ECB4 - "LIBS:muimaster.library" Hunk 0000 Offset 0005C75C
----> $44a3ecb4: MOVE.B    (A0),D1
----> $44a3ecb6: CMP.B     D1,D0
----> $44a3ecb8: BNE.S     $44a3ecbe
----> $44a3ecba: MOVE.L    A0,A1
----> 449EF092 - "LIBS:muimaster.library" Hunk 0000 Offset 0000CB3A
----> $449ef092: MOVE.L    D0,A0
----> $449ef094: ADDQ.L    #$8,A7
----> $449ef096: TST.L     A0
----> $449ef098: BEQ.S     $449ef0b2
----> 449EDD60 - "LIBS:muimaster.library" Hunk 0000 Offset 0000B808
----> $449edd60: BRA.S     $449edd64
----> $449edd62: CLR.L     D0
----> $449edd64: MOVE.L    (A7)+,D2
----> $449edd66: MOVE.L    (A7)+,D3
----> 450F6FE8 - "LIBS:mui/Mesa.mcp" Hunk 0000 Offset 00001190
----> $450f6fe8: LEA       $0004(A7),A7
----> $450f6fec: MOVE.L    D0,$0010(A2)
----> $450f6ff0: CLR.L     -(A7)
----> $450f6ff2: PEA       $450f6140(PC)
----> 450F754C - "LIBS:mui/Mesa.mcp" Hunk 0000 Offset 000016F4
----> $450f754c: MOVE.L    A4,-(A7)
----> $450f754e: MOVE.L    (A1),D0
----> $450f7550: SUBI.L    #$80425242,D0
----> $450f7556: LEA       $450f2148.L,A4
Name: "MUI"

Change History (5)

comment:1 Changed 5 years ago by Jens Maus

Description: modified (diff)

comment:2 Changed 5 years ago by Thore Böckelmann

Component: undefinedmuimaster.library
Milestone: MUI 3.9-2014R2
Owner: set to Thore Böckelmann
Priority: undecidednormal
Status: newassigned

comment:3 Changed 5 years ago by Thore Böckelmann

A quick investigation prooved that Mesa.mcc is at fault here. The label for a checkmark object must be a pointer to a string, not just a single character.

comment:4 Changed 5 years ago by Thore Böckelmann

Resolution: fixed
Status: assignedclosed

In 3617:

  • masterobj.c: the function to extract shortcut characters from a string now accepts single characters instead of string as well to avoid invalid memory accesses of applications or classes which definitely misobey the Autodocs and pass the wrong kind of thing. This closes #41.

comment:5 Changed 4 years ago by Thore Böckelmann

Milestone: MUI 3.9-2014R23.9-2014R2

Milestone renamed

Note: See TracTickets for help on using tickets.