Opened 10 months ago

Closed 9 months ago

Last modified 9 months ago

#367 closed bug (fixed)

"\33I[" to display pictures inside a NList doesn't work anymore

Reported by: Guillaume Boesel Owned by: Thore Böckelmann
Priority: normal Milestone: 5.0-2018R1
Component: foreign class Version: 5.0-2017R4
Severity: minor Keywords:
Cc: OS Platform: AmigaOS4
Blocked By: Blocking:
Release Notes:

Description

Summary

Use of "\33I[5:path_of_a_picture]" or "\33I[6:xx]" doesn't work anymore inside a NList to display a picture.
It worked before the MUI 5.0-2017R4 release

Steps to reproduce

Use \33I[6:30] or \33I[5:path_of_a_picture] inside a NList

Expected results

-See MUI_21_46_OK.jpg attached

Actual results

-See MUI_21_110_KO.jpg attached

To be certain, I fallback to previous MUI (21.46) and it works as expected. Revert to 21.110, it doesn't work.

Thanks

Attachments (3)

MUI_21_46_OK.jpg (455.2 KB) - added by Guillaume Boesel 10 months ago.
It works with MUI 21.46
MUI_21_110_KO.jpg (402.2 KB) - added by Guillaume Boesel 10 months ago.
But not with latest 21.110
NList_os4.lha (141.8 KB) - added by Thore Böckelmann 9 months ago.
fixed NList.mcc 20.141 for AmigaOS4

Download all attachments as: .zip

Change History (13)

Changed 10 months ago by Guillaume Boesel

Attachment: MUI_21_46_OK.jpg added

It works with MUI 21.46

Changed 10 months ago by Guillaume Boesel

Attachment: MUI_21_110_KO.jpg added

But not with latest 21.110

comment:1 Changed 10 months ago by Thore Böckelmann

muimaster.library 21.46 is the one of the 5.0-2017R1 release. What about R2 and R3?

comment:2 Changed 10 months ago by Thore Böckelmann

And do you change MUI releases only or NList releases as well?

comment:3 Changed 10 months ago by Guillaume Boesel

I changes MUI release AND contributions using AmiUpdate.

Tested R1 R2 R3, all worked fine. Even R4 works fine with Nlist.mcc 20.140. Problem appeared when amiupdate download and install R4 contributions and more specifically NList.mcc 20.141.

With R4 installed with NList.mcc 20.141 (therefore bug state), only reverting to NList.mcc 20.140 solve the problem.

comment:4 Changed 10 months ago by Thore Böckelmann

Component: undefinedforeign class
Milestone: future release5.0-2018R1
Owner: set to Thore Böckelmann
Priority: undecidednormal
Status: newassigned

I finally found the commit which causes the issue. The simple solution would be to just revert it, but then the debug build of MUI would throw out warnings about failed layout operations again.

I'll see if I can find a better solution which fixes the issue while still avoiding the warnings.

Changed 9 months ago by Thore Böckelmann

Attachment: NList_os4.lha added

fixed NList.mcc 20.141 for AmigaOS4

comment:5 Changed 9 months ago by Thore Böckelmann

I think I found an elegant solution for this issue. Please try the attached version of NList.mcc.

comment:6 Changed 9 months ago by Guillaume Boesel

I confirm, it works now.

Will you bump the NList.mcc version and correct the AmiUpdate package ?

Thx

comment:7 Changed 9 months ago by Thore Böckelmann

Resolution: fixed
Status: assignedclosed

The MUI contrib archive will be regenerated for the next scheduled release only. But of course I can do a proper NList release ahead of that and upload the NList archive to Aminet and os4depot.net.

comment:8 Changed 9 months ago by Guillaume Boesel

"But of course I can do a proper NList release ahead of that and upload the NList archive to Aminet and os4depot.net."

Yes, please. I will be able to link this new NList archive in my zTools thread.

comment:9 Changed 9 months ago by Thore Böckelmann

NList 0.123 has been released to Aminet and os4depot.net. Currently the archives are in the upload queue. I should not take too long before they go public.

comment:10 Changed 9 months ago by Guillaume Boesel

Thank you

Note: See TracTickets for help on using tickets.