Opened 22 months ago

Closed 3 months ago

Last modified 3 months ago

#330 closed enhancement (wontfix)

Add shortcuts in main buttons of MUI prefs

Reported by: Samir Hawamdeh Owned by:
Priority: normal Milestone: 5.0-2018R3
Component: translation Version: 5.0-2016R3
Severity: minor Keywords:
Cc: OS Platform: All
Blocked By: Blocking:
Release Notes:



The main buttons in MUI prefs lacks a proper shortcuts in order to select them via keyboard

I mean that one:


In english they might become:


Of course If this combination does not interferise with other shortcuts present :-)

Attachments (1)

avviso.png (8.1 KB) - added by Samir Hawamdeh 3 months ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 22 months ago by Thore Böckelmann

Although this sounds like a sensible request it might turn out to be not possible as easy as it seems. The point is that certain shortcut characters are already used otherwise. For english this work, but for example for german the translation for "Cancel" is "Abbrechen" and "A" is used for the "Save as" menu item already. I could use the "c" like in english, but I think you see the global problem to accomplish this task in all languages. For the italian translation we have the same problem with "Annulla". "n" and "l" are currently unused.

What makes the problem even worse are 3rd party .mcp modules. Usually such modules should not use any shortcuts for any of their labels/objects. MUI will try to distribute as many available shortcuts as possible automatically. But if a module does this itself already and uses "U" as shortcut for one of its own objects then MUI's own "Use" button will have a duplicate shortcut.

comment:2 Changed 3 months ago by Thore Böckelmann

Milestone: future release5.0-2018R3
Resolution: wontfix
Status: newclosed

I just iterated over old tickets and also looked at the recently finished french translation. The french translation features shortcuts for the four bottom buttons of MUI prefs, although the built in english texts don't specify any shortcuts. There is absolutely no reason why a specific translation shouldn't provide any shortcuts when the built in string don't provide shortcuts. In the end it is the translator's task to provide suitable shortcuts anyway, no matter which shortcut (if any at all) is used for the built in strings.

To make it short: just go ahead and add shortcuts in the italian translation if you like. There is nothing that MUI needs to provide first of all.

comment:3 Changed 3 months ago by Thore Böckelmann

Component: undefinedtranslation
Priority: undecidednormal

comment:4 Changed 3 months ago by Samir Hawamdeh

Mmm ok meanwhile i found a broken shortcut into the expired window, pls can you fix it

Grab attached

Changed 3 months ago by Samir Hawamdeh

Attachment: avviso.png added

comment:5 Changed 3 months ago by Thore Böckelmann

That's because MUI is falling back to EasyRequest(), because at the time MUI displays the expiry requester there is no MUI application object yet. And EasyRequest() of intuition.library does not support shortcuts.

That's what you get when you add shortcuts where the developer intentionally did not provide shortcuts.

I think I need to extend the EasyRequest() fallback to filter out such MUI specific things.

comment:6 Changed 3 months ago by Thore Böckelmann

In 6320:

  • masterreq.c: remove underscores and other MUI specific characters from the buttons string when falling back to EasyRequest(). This refs #330.

comment:7 Changed 3 months ago by Thore Böckelmann

In 6321:

  • masterreq.c, mastertext.c: use a plain text version of the body text passed to MUI_RequestA() when falling back to EasyRequest(). This refs #330.
Note: See TracTickets for help on using tickets.