Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#311 closed bug (fixed)

MUI4 or MUI5. Bugs found with SongPlayer

Reported by: fernandoacemail@… Owned by: Thore Böckelmann
Priority: normal Milestone: 5.0-2016R2
Component: List.mui Version: 4.0-2016R2
Severity: minor Keywords:
Cc: OS Platform: AmigaOS3
Blocked By: Blocking:
Release Notes:

Description

Hi:

This is trying SongPlayer for my new AKReal update. Of course this is not about the SongPlayer program but the MUI settings. I've found two problems:

-First: The name of the song playing isn't shown. It was shown with MUI38. It will appear if you just move the size of the window of SongPlayer. It happens with MUI4 or MUI5.

MUI38: http://hostthenpost.org/uploads/8d4fb1cdebe319b2511dfea8885496bd.png
MUI5: http://hostthenpost.org/uploads/67764f7bd4ebbf7597a1d629377e605e.png

-Second: As I commented by email, I can not get transparency in some of the letters.

http://hostthenpost.org/uploads/568bad6667ded97c28023777459d6128.png

Attachments (6)

songplayer_mui38.png (717.6 KB) - added by Thore Böckelmann 3 years ago.
SongPlayer with MUI 3.8
songplayer_mui50.png (789.7 KB) - added by Thore Böckelmann 3 years ago.
SongPlayer with MUI 5.0
songplayer_mui50_background.png (753.8 KB) - added by Thore Böckelmann 3 years ago.
SongPlayer with MUI 5.0, wrong background in file description
Nightly build.png (875.4 KB) - added by Fernando Martín Morillo 3 years ago.
Nightly Build Shorted Songplayer.png (873.7 KB) - added by Fernando Martín Morillo 3 years ago.
Scopes with transparency.png (893.8 KB) - added by Fernando Martín Morillo 3 years ago.

Change History (18)

Changed 3 years ago by Thore Böckelmann

Attachment: songplayer_mui38.png added

SongPlayer with MUI 3.8

Changed 3 years ago by Thore Böckelmann

Attachment: songplayer_mui50.png added

SongPlayer with MUI 5.0

Changed 3 years ago by Thore Böckelmann

SongPlayer with MUI 5.0, wrong background in file description

comment:1 Changed 3 years ago by Thore Böckelmann

Component: undefinedList.mui
Milestone: future release5.0-2016R2
Owner: set to Thore Böckelmann
Priority: undecidednormal
Status: newassigned

First of all, please don't use external file hosters, but attach files here directly. The external files will be unavailable at some time and a later reference is impossible then.

Regarding the first issue, there seems to be a difference in how List class is implemented in MUI 3.8 and MUI 5.0. Right now I have no idea where to look, but I think the issue cannot be too hard to find, as the list's contents are displayed correctly after resizing the window.

Regarding the second issue, it seems that SongPlayer is trying to implement the background inheritance for the label objects itself, because MUI 3.8 did not offer this feature yet, and hence sets propagates the window background image to all the label objects. I'll see what can be done about that to get the images' position adjustment correct to match the window background.

Next time please open separate tickets for unrelated bugs.

comment:2 Changed 3 years ago by Thore Böckelmann

In 5520:

  • List.c: when setting MUIA_List_Title a title bar relayout is done if and only if a really new title string is set. This fixes the resized to minimum width columns of SongPlayer. This refs #311.

Changed 3 years ago by Fernando Martín Morillo

Attachment: Nightly build.png added

comment:3 Changed 3 years ago by Fernando Martín Morillo

Great, now the title is shown from the start with the Nightly build from yesterday 20 sept. Now only keeps to solve the transparency.

BTW can I also get transparency in the scope?

comment:4 Changed 3 years ago by Thore Böckelmann

After lots of investigation I came to the conclusion that the second issue cannot be solved easily, if at all. Let me explain.

With MUI 3.8 the default background spec for objects was a NULL pointer. This caused MUI to recursively fall back to the background image of the object's parent object untill either a non-NULL pointer was found or the window object was reached. This is MUI 3.8's kind of background inheritance. The inconsistency here is the fact that MUII_WindowBack also has the same value (zero) and hence it is impossible to tell whether the window background should be used or whether the parent object's background is to be inherited.

That's why the background inheritance scheme was changed for MUI4. The default background is a non-NULL but empty string. This makes it possible to solve the inconsistency described above. But the price to pay is that old applications which explicity set NULL as background to enforce background inheritance according to the old scheme will now fall back to the window background, which definitely is not desired. But since NULL and 0 are the same value from an integer's point of view it is impossible to prefer one over the other. That's why you end up with the wrong background for the label objects, or a least the correct background, but wrongly shifted in respect to the surrounding group object.

comment:5 in reply to:  3 Changed 3 years ago by Thore Böckelmann

Replying to Retrofan:

BTW can I also get transparency in the scope?

Just configure the gauge background to be inherited from the parent (MUI prefs → Buttons → Gauge → background setting → like parent object). But this should be done specially for SongPlayer only instead of globally.

comment:6 Changed 3 years ago by Thore Böckelmann

BTW, running SongPlayer on MorphOS exposes exactly the same wrong background as with MUI for AmigaOS. So were are not alone here…

Changed 3 years ago by Fernando Martín Morillo

comment:7 Changed 3 years ago by Fernando Martín Morillo

Do not worry so much. If it can't be done, I can change the SongPlayer prefs ;)

comment:8 Changed 3 years ago by Fernando Martín Morillo

What about the scope, can I change its background and use another image?

comment:9 Changed 3 years ago by Fernando Martín Morillo

Ups. Yes, I see your answer now.

Changed 3 years ago by Fernando Martín Morillo

comment:10 Changed 3 years ago by Fernando Martín Morillo

Yes, the scopes can look nice with transparency and some backgrounds ;)

comment:11 Changed 2 years ago by Thore Böckelmann

Resolution: fixed
Status: assignedclosed

Is there anything left to be done for this ticket? I know that MUI3.8 and MUI5 are not 100% compatible regarding background handling, but there is nothing I can do against that. The only true solution would be to fix this in SongPlayer itself, but I think that is unlikely to happen.

So from my point of view all is done. At least the initial issue of the invisible list columns is fixed.

comment:12 Changed 2 years ago by Fernando Martín Morillo

Yes, it is done for me too, thanks.

Note: See TracTickets for help on using tickets.