Opened 4 years ago

Closed 4 years ago

#246 closed bug (fixed)

MUIM_Title_Close isn't called anymore

Reported by: Andreas Falkenhahn Owned by: Thore Böckelmann
Priority: normal Milestone: 4.0-2015R3
Component: Title.mui Version: 4.0-nightly build
Severity: minor Keywords:
Cc: OS Platform: All
Blocked By: Blocking:
Release Notes:

Description

I noticed that with the latest MUI nightlies, MUIM_Title_Close isn't called anymore when clicking the "Close" gadget of a register tab. This used to work in the MUI that came with OS4.1 FE but it doesn't work with recent nightlies any longer.

For a demo program, run Dynamic3.hws from the MUI Royale distribution and try to close a register tab. It won't work with current nightlies.

Change History (3)

comment:1 Changed 4 years ago by Thore Böckelmann

OS Platform: undefinedAll
Owner: set to Thore Böckelmann
Priority: undecidednormal
Status: newassigned

This definitely works with the MUI Titles demo. I cannot tell how MUIRoyale works internally but for the MUI demo the method is definitely triggered. The Dynamic3 demo seems to add a close button on its own. That one must call the MUIM_Title_Close method for the Title object along with the corresponding tab object which is to be closed.

comment:2 Changed 4 years ago by Thore Böckelmann

Ahh, sorry, my fault. The Title class calls the MUIM_Title_Close method for the tab object instead of the Title object itself. In turn the Titles demos incorrectly implements that method for the wrong class and hence seems to work correctly. I will fix that ASAP.

comment:3 Changed 4 years ago by Thore Böckelmann

Resolution: fixed
Status: assignedclosed

In 4905:

  • Title.c, demos/Title.c: the MUIM_Title_Close method was called for the wrong object and hence did not work as expected. However, the Title demo application implemented the method for the wrong class and continued to work. This closes #246.
Note: See TracTickets for help on using tickets.