Opened 3 years ago

Last modified 14 months ago

#194 new bug

MCC Calendar 18.3 crash under MUI4

Reported by: Samir Hawamdeh Owned by:
Priority: undecided Milestone:
Component: foreign class Version: 4.0-nightly build
Severity: minor Keywords:
Cc: OS Platform: AmigaOS4
Blocked By: Blocking:
Release Notes:

Description

Summary

The old MCC Calendar 18.3 (68k) crash badly under MUI4 (AmigaOS4)

http://aminet.net/package/dev/mui/MCC_Calendar

Steps to reproduce

  1. Just copy the class files
  2. Start MUI and select the class from the prefs

Expected results

Should work :-)

Actual results

It doesn't !

Attachments (5)

Crashlog_MUI_2015-04-11_13-38-20.txt (27.1 KB) - added by Samir Hawamdeh 3 years ago.
calendar-hits.txt (2.3 KB) - added by Mikhail Malyshev 2 years ago.
crash.png (811.1 KB) - added by Samir Hawamdeh 14 months ago.
Crashlog_MUI_2016-08-19_14-04-32.txt (28.1 KB) - added by Samir Hawamdeh 14 months ago.
Crashlog_MUI_2016-09-06_02-14-26.txt (25.8 KB) - added by Samir Hawamdeh 14 months ago.
Crash with MUI 5.0 SVN r5515

Download all attachments as: .zip

Change History (21)

Changed 3 years ago by Samir Hawamdeh

comment:1 Changed 3 years ago by Thore Böckelmann

Unfortunately I am not able to reproduce this issue, at least no on AmigaOS3. The crashlog just points to 68k code, in contrast to the crashlog from #192. Finally the source code of Calendar.mcc is not available.

As long as these hurdles exist I am affraid I cannot do anything, because I have no clue where to look for a problem.

comment:2 Changed 3 years ago by Samir Hawamdeh

@Thore

Understand, well i might contact Alfonso Ranieri asking for the code ..
Aniway don't know if because your previews changes (for the other problematic class i've reported you) but now the crash in this class become skippable .. of course it still the same error as before (when opened in MUI prefs), but more or less the class seems working now :-)

comment:3 Changed 3 years ago by Thore Böckelmann

If the crash still occurs then it would be nice to get a new crashlog. Perhaps it looks different to the first one. At least for LayGroup.mcp the log definitely pointed to PPC code which then could be identified very easily.

And please tell me whether you get a reply from Alfonso. I already had contact with him via EMail about 3 years ago. Back then he emerged only when either Jens or me did some changes to his public OpenSource classes which did not fully fit into his MUI4-only world. He then simply reverted lots of our changes without trying to preserve the compatibility to MUI3. After that he crept back under his stone and never did any further work on the classes. Not really a good team player from my point of view…

comment:4 Changed 3 years ago by Samir Hawamdeh

@Thore

If the crash still occurs then it would be nice to get a new crashlog. Perhaps it looks different to the first one.

Crash still exactly the same, just now it's become skippable

And please tell me whether you get a reply from Alfonso. I already had contact with him via EMail about 3 years ago.

I just mailed him, let's see what he say (if he reply)

Back then he emerged only when either Jens or me did some changes to his public OpenSource
classes which did not fully fit into his MUI4-only world. He then simply reverted lots of our changes > without trying to preserve the compatibility to MUI3. After that he crept back under his stone and
never did any further work on the classes. Not really a good team player from my point of view…

It's the classic attitude of most MorphOS devs, well not that others are so better when we speaking about collaboration ..
Aniway after all i hope your changes were preserved ..

comment:5 Changed 2 years ago by Thore Böckelmann

Any news regarding an answer from Alfonso?

comment:6 Changed 2 years ago by Samir Hawamdeh

Not yet, he doesn't replied to my mail … :-/

comment:7 Changed 2 years ago by Thore Böckelmann

Any progress on this topic?

comment:8 Changed 2 years ago by Samir Hawamdeh

Still no … he didn't replied :-/

Changed 2 years ago by Mikhail Malyshev

Attachment: calendar-hits.txt added

comment:9 Changed 2 years ago by Mikhail Malyshev

Can confirm that there are problems.

When entering the prefs for Calendar for the first time we get a hit. (MUI4-OS3 nightly)

https://muidev.de/attachment/ticket/194/calendar-hits.txt

comment:10 Changed 14 months ago by Thore Böckelmann

In 5500:

  • String.c: fixed a possible NULL pointer access. This refs #194.

comment:11 Changed 14 months ago by Thore Böckelmann

Please try if the latest change fixes the hits. At least I don't get any hits anymore.

comment:12 Changed 14 months ago by Samir Hawamdeh

@Thore

Tested today under MUI4 SVN-r5500 … but apparently the problem still present

comment:13 Changed 14 months ago by Thore Böckelmann

Can you provide a new crashlog please? At least on AmigaOS3 there are no more crashes.

Just for the record, Calendar.mcc never caused immediate crashes for me, but only when I started MUI prefs a second time. The crash finally happened in String.mui in a place which could not really be responsible for a crash. The pointer in question definitely was non-NULL but as soon as the code dereferenced it it did become NULL, no matter how much debug output I added around that place to output the non-NULL value of that pointer. The workaround was to precalculate the obtained value. Then the crash (on AmigaOS3) was gone.

So basically the real bug is still there, most probably in Calendar.mcc, but maybe in MUI.

comment:14 Changed 14 months ago by Samir Hawamdeh

Ok, crashlog and a grab attached aswell

Changed 14 months ago by Samir Hawamdeh

Attachment: crash.png added

Changed 14 months ago by Samir Hawamdeh

comment:15 Changed 14 months ago by Thore Böckelmann

Probably this issue has exactly the same reason as #307 and #309. If I guessed right this might be fixed with the next nightly build of both MUI4 and MUI5. Please check again with that version.

Changed 14 months ago by Samir Hawamdeh

Crash with MUI 5.0 SVN r5515

comment:16 Changed 14 months ago by Samir Hawamdeh

Tested but apparently nothing changed, see crashlog above

Note: See TracTickets for help on using tickets.