Opened 3 years ago

Closed 3 years ago

Last modified 14 months ago

#193 closed bug (fixed)

Image not centered in MUIA_ContextMenu. OK in MUIA_Application_Menustrip

Reported by: Guillaume Boesel Owned by: Thore Böckelmann
Priority: undecided Milestone: 4.0-2015R2
Component: Popmenu.mui Version: 4.0-nightly build
Severity: minor Keywords:
Cc: OS Platform: AmigaOS4
Blocked By: Blocking:
Release Notes:

Description

Summary

Adding AISS picture in a MUIA_ContextMenu element make the picture not height centered with the text at his right (see MUIA_Menuitem_Image_KO.JPG).

Nevertheless, using the exact same picture works fine in MUIA_Application_Menustrip (see attached MUIA_Menuitem_Image_OK.JPG).

Using sysimage is OK in both case, well centered.

Steps to reproduce

  1. Add a bitmap.image object to a MUIA_ContextMenu/MUIA_Menuitem_Image
  2. Add a bitmap.image object to a MUIA_Application_Menustrip/MUIA_Menuitem_Image
  3. Compare vertical centering of the 2 pictures

Expected results

MUIA_ContextMenu/MUIA_Menuitem_Image PNG picture centered as MUIA_Application_Menustrip/MUIA_Menuitem_Image

Actual results

MUIA_ContextMenu/MUIA_Menuitem_Image PNG picture shifted (see MUIA_Menuitem_Image_KO.JPG)

Notes

Thank you for the latest SDK release with DrawInfo function.

Guillaume

Attachments (3)

MUIA_Menuitem_Image_KO.JPG (85.4 KB) - added by Guillaume Boesel 3 years ago.
MUIA_Menuitem_Image_OK.JPG (46.3 KB) - added by Guillaume Boesel 3 years ago.
PopMenu_OK.JPG (69.0 KB) - added by Guillaume Boesel 3 years ago.

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by Guillaume Boesel

Attachment: MUIA_Menuitem_Image_KO.JPG added

Changed 3 years ago by Guillaume Boesel

Attachment: MUIA_Menuitem_Image_OK.JPG added

comment:1 Changed 3 years ago by Guillaume Boesel

The previous tests were made under OS4 FE.
Under OS4.1.6 :

-MUIA_ContextMenu/MUIA_Menuitem_Image is still not aligned, no change

-but MUIA_Application_Menustrip/MUIA_Menuitem_Image doesn't work at all, the picture is not displayed but, hopefully, it doesn't crash

comment:2 Changed 3 years ago by Thore Böckelmann

Component: Menuitem.muiPopmenu.mui
Milestone: 4.0-2015R2
Owner: set to Thore Böckelmann
Status: newassigned

comment:3 Changed 3 years ago by Thore Böckelmann

Resolution: fixed
Status: assignedclosed

In 4643:

  • Popmenu.c: the menu item text is now correctly centered vertically when external images are used. This closes #193.

Changed 3 years ago by Guillaume Boesel

Attachment: PopMenu_OK.JPG added

comment:4 Changed 3 years ago by Guillaume Boesel

Wonderful, it works ! (see PopMenu_OK.JPG)

Thank you very much for your reactivity.
Guillaume

Note: See TracTickets for help on using tickets.