Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#176 closed bug (fixed)

Crash when changing the font dimention on the fly

Reported by: Samir Hawamdeh Owned by: Thore Böckelmann
Priority: normal Milestone: 4.0-2015R2
Component: Popstring.mui Version: 4.0-nightly build
Severity: minor Keywords:
Cc: OS Platform: AmigaOS4
Blocked By: Blocking:
Release Notes:

Nested opened popobjects (i.e. the color selection in the font selection) can now be closed automatically when the outmost object is closed (i.e. by changing pages in MUI prefs).

Description

Summary

I was changing the color fonts in the "windows" prefs (Font: Big), then without saving i switched to the "Info" section in order to verify the results.

To do that i mantained the subwindows opened, but just when i select another section (Info) i got a crash related to the ASL requester

Attachments (2)

Crashlog_MUI-Asl-Popup-Task_2015-03-09_00-24-37.txt (29.0 KB) - added by Samir Hawamdeh 5 years ago.
crash_mui-asl.png (238.2 KB) - added by Samir Hawamdeh 5 years ago.

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by Samir Hawamdeh

comment:1 Changed 5 years ago by Thore Böckelmann

Which subwindow did you leave open? Your description is a bit vague in this respect.

comment:2 Changed 5 years ago by Samir Hawamdeh

To reproduce it follow that (long) steps:

1 - Open MUI and select the "Windows" section

2 - Under the Fonts area, select the "Big" one clicking into its related "FF" button

3 - At this point the "Select font" subwindow will be opened, now click into the "OutLine" button

4 - At this point you will have another subwindow open (Adjust pen), select the azure color and press "Use"

5 - At this point you still have the previews "Select font" subwindow opened, however without closing it, try to select the "Info" area in order to see how the new color were applied to the big fonts —→

Exact at this point you should got the crash

Changed 5 years ago by Samir Hawamdeh

Attachment: crash_mui-asl.png added

comment:3 Changed 5 years ago by Thore Böckelmann

Component: undefinedPopstring.mui
Milestone: 4.0-2015R2
Owner: set to Thore Böckelmann
Priority: undecidednormal
Status: newassigned

comment:4 Changed 5 years ago by Thore Böckelmann

In 4574:

  • Popstring.c: invoke the close method when the popstring object is cleaned up. This is consistent to how other popup objects react when they are cleaned up. This refs #176 but does not yet fix the invalid memory accesses in case there are nested opened popup objects.

comment:5 Changed 5 years ago by Thore Böckelmann

Resolution: fixed
Status: assignedclosed

In 4575:

  • popcommon.c: do all necessary cleanup work during MUIM_Hide instead of MUIM_GlobalCleanup. This closes #176.

comment:6 Changed 5 years ago by Thore Böckelmann

Release Notes: modified (diff)

comment:7 Changed 4 years ago by Thore Böckelmann

In 4774:

  • Application.c, Window.c, popcommon.c: remember the "config update active" state at application level instead of object level. This refs #176 and closes #217.

comment:8 Changed 4 years ago by Thore Böckelmann

In 4774:

  • Application.c, Window.c, popcommon.c: remember the "config update active" state at application level instead of object level. This refs #176 and closes #217.
Note: See TracTickets for help on using tickets.